From ebac7d807ed08c81641374162ee41fb3fe4168d3 Mon Sep 17 00:00:00 2001
From: jack <jack@csrx.ru>
Date: Sun, 22 Mar 2026 20:22:50 +0700
Subject: [PATCH] fix(backup): remove unsupported --storage-class COLD for
 Timeweb S3

Timeweb S3 doesn't support per-object storage class via API parameter.
Cold storage is configured at bucket level in Timeweb control panel.
Also: make S3 upload failures explicit (exit 1) instead of silently ignored.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 roles/backup/templates/backup.sh.j2 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/roles/backup/templates/backup.sh.j2 b/roles/backup/templates/backup.sh.j2
index 4dd9452..bbd0491 100644
--- a/roles/backup/templates/backup.sh.j2
+++ b/roles/backup/templates/backup.sh.j2
@@ -117,10 +117,9 @@ AWS_ACCESS_KEY_ID="{{ s3_access_key }}" \
 AWS_SECRET_ACCESS_KEY="{{ s3_secret_key }}" \
   aws s3 cp "${ARCHIVE}" "s3://{{ s3_bucket }}/data/$(basename "${ARCHIVE}")" \
     --endpoint-url "{{ s3_endpoint }}" \
-    --storage-class COLD \
     --no-progress \
   && log "  → S3 upload complete" \
-  || log "  ⚠ S3 upload failed (local backup still intact)"
+  || { log "  ⚠ S3 upload FAILED"; exit 1; }
 
 # ── Cleanup old local backups ─────────────────────────────────────────────────
 log "Removing local backups older than ${KEEP_DAYS} days..."